Danek Duvall wrote:
On Tue, Jun 09, 2009 at 02:36:33PM -0700, Brock Pytlik wrote:
http://cr.opensolaris.org/~bpytlik/ips-8534-v1/
t_pkg_install.py:
- I wonder if you couldn't replace the dozens of progress tracker and
ImageInterface creation calls with calls to a single helper function
that just did it all for you. Perhaps _do_install() or image_create()
could hide the calls entirely? I don't care too much.
I could pull it out to a separate function. Putting it into do_install
doesn't feel right to me, but making it what image create returns has
possibilities I think. I'll look into that more closely.
- In all the other places you use lambdas, you don't put a space after
the colon.
Fixed.
- I also wonder why you're making a ton of install changes to fix a bug
that's about pkgsend. I'm okay with the cli -> api change, but that
doesn't appear to be the target of this bug.
You're right. I'll file an additional bug and tag this wad with it.
testutils.py:
- _do_finish() can be __do_finish(), no?
Yep
Danek
Brock
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
