Thanks for looking at this, David. On Wed, Jul 01, 2009 at 09:46:41AM -0700, david.co...@sun.com wrote: >> I haven't had any further comments on this webrev. I just updated it to >> include fixes to get distro-import to properly import SUNWpython-pycurl, >> and to make sure the dependency is reflected in SUNWipkg. If no one has >> anything else to add, I'll consider putting this back tomorrow. > > I only looked at the metadata bits. > > src/pkgdefs/Makefile > > Looks like we keep the packages listed in alphabetical order so > please keep this.
Fixed SUBDIRS. I didn't see anything else in alphabetical order here. > src/pkgdefs/SUNWipkg/prototype > > Not sure if it the current prototype is sorted by pathname but > it should be. In any case, it looks like your addition isn't > so please move this up prior to the "variant" entries. I re-sorted the entire file instead. > src/pkgdefs/SUNWpython-pycurl/pkginfo > > Please make the NAME value more descriptive (see pkginfo(4) for > more details) since this ends up as the package summary. Would you be more specific about what you'd like this to say? I took a look at pkginfo(4) and the other packages in pkgdefs/*/pkginfo. They all seem to use the package's name as the value for NAME. The package delivers PycURL. I'm a bit lost about what this is supposed to say instead. > src/pkgdefs/SUNWpython-pycurl/prototype > > Same comment as with SUNWipkg about sorting by pathname. Re-sorted as well. > src/util/distro-import/118/common/SUNWpython-pycurl > > Line 1 - That should be "package SUNWpython-pycurl" :-) Thanks for catching that. -j _______________________________________________ pkg-discuss mailing list pkg-discuss@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
