johan...@sun.com wrote:
>> src/modules/client/transport/engine.py:
line 516: where is data defined? did you mean treq.data?
Yes. That's a leftover from converting from a tuple to the
TransportRequest object.
Since the client doesn't use POST (that I know of) anymore, does this
mean you need an explicit POST test and test suite just for transport?
line 552: could be a function
I don't understand this comment. Would you please clarify? Line 552 is
the definition for the function __teardown_handle().
This function doesn't use self, so it could be a @classmethod ...
src/modules/client/transport/fileobj.py:
line 28: unused import
The version of the webrev that I'm looking at doesn't have an import
here.
Nevermind.
Cheers,
--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
pkg-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
