On Wed, Jul 01, 2009 at 05:07:44PM -0500, Shawn Walker wrote: > johan...@sun.com wrote: > >> src/modules/client/transport/engine.py: >>> line 516: where is data defined? did you mean treq.data? >> >> Yes. That's a leftover from converting from a tuple to the >> TransportRequest object. > > Since the client doesn't use POST (that I know of) anymore, does this > mean you need an explicit POST test and test suite just for transport?
Search should still be using POST for sending a search that contains multiple queries to the server. If the test suite isn't testing search in this manner, we should probably file a bug to get it improved. >>> line 552: could be a function >> >> I don't understand this comment. Would you please clarify? Line 552 is >> the definition for the function __teardown_handle(). > > This function doesn't use self, so it could be a @classmethod ... Ok, got it. Changed to @staticmethod, since IIRC @classmethod provides the name of the class as an argument. -j _______________________________________________ pkg-discuss mailing list pkg-discuss@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
