[email protected] wrote:
On Mon, Jul 20, 2009 at 06:53:31PM -0700, Brock Pytlik wrote:
[email protected] wrote:
Folks,
This is a small change to get the transport to send the UUID with the
file/0 operation. It's about 15 lines of change.
http://cr.opensolaris.org/~johansen/webrev-10149/
Thanks,
-j
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
LGTM, only question I have is whether this should be an optional
argument or not. Are there others places where we do (or want) to call
get_files without a UUID supplied in the header? Maybe it makes sense to
have it be an optional argument in the abstract/parent class, but
required in our HTTPRepo implementation?
I'm not sure I understand. The argument is optional to get_files.
Check out lines 58 and 177. If the caller doesn't supply these
arguments, they default to None.
-j
Right, I'm asking whether it should be an optional argument, especially
in the subclass.
Brock
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
