[email protected] wrote:
On Mon, Jul 20, 2009 at 08:59:40PM -0500, Shawn Walker wrote:
[email protected] wrote:
Folks,
This is a small change to get the transport to send the UUID with the
file/0 operation. It's about 15 lines of change.
http://cr.opensolaris.org/~johansen/webrev-10149/
Only thing I'd ask for is a test to verify that it is getting sent based
on send-uuid policy.
This test is orthogonal to the changeset. We don't presently have any
tests that check whether the send-uuid policy works, nor do the tests
that look at UUIDs work correctly. The pkg search tests require that we
hard code the number of expected UUIDs, because there's no mechanism in
the header logging to map request -> header. Any time we change the
number of network operations in a transaction, the search test fails in
exotic ways. I'm not keen on adding a new broken test.
-j
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
As a side note, if you think the pkg search uuid tests are more of a
pain than they're worth, feel free to remove them. If I remember right,
they went in b/c search specifically wasn't sending uuid's some of the
time. I'm also happy to fix the tests so they're less broken, but that
was all I could think of to do at the time.
Brock
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
