[email protected] wrote:
On Mon, Jul 20, 2009 at 07:05:07PM -0700, Brock Pytlik wrote:
LGTM, only question I have is whether this should be an optional
argument or not. Are there others places where we do (or want) to
call get_files without a UUID supplied in the header? Maybe it makes
sense to have it be an optional argument in the abstract/parent
class, but required in our HTTPRepo implementation?
I'm not sure I understand. The argument is optional to get_files.
Check out lines 58 and 177. If the caller doesn't supply these
arguments, they default to None.
Right, I'm asking whether it should be an optional argument, especially
in the subclass.
Are you trying to say that this argument should be required? I made it
optional for get_files, because it's optional for every other transport
method. It seemed weird to have it required in one place, but optional
everywhere else.
-j
Yes, I was asking whether it should be required in the subclass. Seems
like your answer is no, which is fine with me.
Brock
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
