Shawn Walker wrote:
Brock Pytlik wrote:
Webrev:
http://cr.opensolaris.org/~bpytlik/ips-9845-v1/
This cleans up some error handling for malformed search queries.
src/modules/query_parser.py:
line 49, 61: Generally speaking, we've avoided subclassing the
python standard exceptions as the exception structure can and does
change. Not only that, it makes it difficult to differentiate between
a more serious python exception and a 'logical' exception we've
raised. I'd prefer to see both of these inherit from a QueryError
class or the like instead. And yes, I'm aware that you did this
because the actual exception was a ValuError to start with, but I
still believe it should not inherit from ValueError.
Ok, fine with me.
[snip]
src/tests/cli/t_api_search.py:
line 1048: won't this fail if the language the test suite is run in
is not English given that the expected_strings passed in are not?
Sure, I'll mark it for translation.
Brock
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
