Danek Duvall wrote:
On Mon, Jul 27, 2009 at 06:17:53PM -0700, Brock Pytlik wrote:
http://cr.opensolaris.org/~bpytlik/ips-9845-v2/
Two small nits:
- The new IncompleteQuery exception has a very long message for something
that's essentially an internal error. Is the user ever going to need
to understand what's going on here, or can a shorter message do the
trick?
The user should never see this message. The only way we can hit it is if
a) we do the conversion wrong in our own code, or b) someone sends us
handcrafted, broken, search request to the server (ie, they used wget to
run a search). Mostly, it will only appear if someone types in
"http://<my repo>/search/1/<garbled query>" In that situation, I thought
a detailed error message would be helpful. It should never appear on the
command line or the gui.
- line 435: I recognize this is from previous code, but why convert the
list into a tuple explicitly?
Cause I didn't realize the decomposition would work on a list. I'll
remove it :)
Thanks,
Brock
Looks fine to me otherwise.
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
