On Mon, Jul 27, 2009 at 06:17:53PM -0700, Brock Pytlik wrote:
> http://cr.opensolaris.org/~bpytlik/ips-9845-v2/
Two small nits:
- The new IncompleteQuery exception has a very long message for something
that's essentially an internal error. Is the user ever going to need
to understand what's going on here, or can a shorter message do the
trick?
- line 435: I recognize this is from previous code, but why convert the
list into a tuple explicitly?
Looks fine to me otherwise.
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
