[email protected] wrote:
Hi Shawn,
I only found one issue.
On Sat, Aug 01, 2009 at 01:55:33AM -0500, Shawn Walker wrote:
webrev:
http://cr.opensolaris.org/~swalker/pkg-10418/
image.py:
- lines 1901 - 1907: These two functions should be removed entirely.
They were put in place as a wrapper around the fmri() methods that
they call because they also needed to look at the rename history.
With rename removed, you should remove these functions and just call
the method in the fmri object directly.
I left them as stubs for the upcoming rename and obsoletion work, and
because the packagemanager, imageplan, etc. currently uses these. I'm
not opposed to removing them if you believe there's little value in
doing so.
Cheers,
--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
