Hi Shawn,
Just nits now.
On Mon, Aug 03, 2009 at 07:25:20PM -0500, Shawn Walker wrote:
> Shawn Walker wrote:
>> Greetings,
>>
>> The following webrev contains fixes for the following issues:
>>
>> 10417 rename v0 support should be removed everywhere
>> 10418 server catalog needs temporary separation from client catalog
>
> Based on review comments, here's an updated webrev for these changes:
> http://cr.opensolaris.org/~swalker/pkg-10418-2/
image.py:
- line 1082 - 1086: It looks like the result of get_catalog is unused
here. This code can probably be removed.
- line 1093 & 1094: Since you've removed the rename check, this no
longer looks for packages with other names. This comment should be
changed, I think.
- line 1104: I don't think you need this call to get_catalog anymore.
That also makes 1103 unnecessary, too.
-j
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
