Bart,
The use of the global variable in the os_unix.py file would seem to
introduce a potential concurrency issue if multiple threads are using
this code. Consider the case where separate threads are operating on
separate user images simultaneously. Currently, the pkg(5) code handles
this, but with this fix, there could be a problem with accessing the
__been_here dictionary.
Instead of checking on every call, can't the module just call the
offending get group name method once as it is loaded? And maybe that
call should be in os_sunos.py rather than os_unix.py is that it is only
done for Solaris?
Thanks.
Tom
Bart Smaalders wrote:
http://cr.opensolaris.org/~barts/reboot_needed/webrev/
9387 pkg fix should honor reboot-needed flag
Note that this fix is designed to prevent the upgrade
of files that require a reboot on a live image; it doesn't
yet deal w/ automatically creating a new BE if that's the
desired behavior.
begin:vcard
fn:Tom Mueller
n:Mueller;Tom
org:Sun Microsystems, Inc.;Update Center Software
adr:;;21915 Hillandale Dr;Elkhorn;NE;68022;USA
email;internet:[email protected]
title:Senior Staff Engineer
tel;work:877-250-4011
tel;fax:877-250-4011
tel;home:402-916-9943
x-mozilla-html:TRUE
version:2.1
end:vcard
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
