Bart Smaalders wrote:

> http://cr.opensolaris.org/~barts/reboot_needed/webrev/

client.py:

  - Don't need continuation characters inside parens.  You also want a
    space after the semicolon.  And you probably want to make some attempt
    at wrapping the output to a reasonable width.

actuator.py:

  - Since you're changing the name of the actuator anyway, could you make
    it "reboot-needed"?  You also need to update the manpage.

api.py:

  - line 595: "and" at the end of the line

Does this work for "pkg fix"?  As far as I can tell, it doesn't, since you
hook in via the api, and pkg fix doesn't go anywhere near that.

Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to