John,
It's working pretty well. I found two minor bugs and I will let you
decide what to do with them.
BUG 1:
Search for *&
> GtkWarning: Failed to set text from markup due to error parsing
markup: Error on line 1: Entity did not end with a semicolon; most
likely you used an ampersand character without intending to start an
entity - escape ampersand as &
- the status bar markup is broken, probably we need to replace all & to
& when updating statusbar.
BUG 2:
Enter space and click on magnifier search icon
> The list of packages is empty, status bar tells that 0 results were found
- expected - nice html page should be in place, exactly like other 0
results found case
- or... do nothing when there are only spaces
Michal
jmr wrote:
Michal - new webrev at:
http://cr.opensolaris.org/~jmr/pm_enhance_search_ui_11669_06Oct_4pm/
bug: 11669 Enhance handling of Search All Publishers to match current
UI Spec
bug: 11699 Missing focus rectangle and missing a11y events on PM start
page
JR
jmr wrote:
Thanks for the feedback Michal, comments below and new webrev
(includes fixes for Padraig's comments):
webrev:
http://cr.opensolaris.org/~jmr/pm_enhance_search_ui_11669_05Oct_535pm/
bug: 11669 Enhance handling of Search All Publishers to match current
UI Spec
bug: 11699 Missing focus rectangle and missing a11y events on PM
start page
JR
Michal Pryc wrote:
John,
Here are few issues which I found:
1.
If I click on the magnifier without entering anything, the PM is
trying to search for "Search (Ctrl-F)"
Some packages are being displayed after which I am getting:
"No packages found in opensolaris.org matching Search (Ctrl-F)"
This is a bug I now check for this and don't allow search when search
text in prompt mode.
2.
I can not right click on the web page with "No packages found..." I
found this while
trying to copy and paste the result to this message. Is this
intentional?
Its just what the GtkHTML control gives by default, no right click
menu. Webkit would provide this type of functionality if we wanted it.
3.
pfexec rm -rf /var/pkg/gui_cache/
- Start PM (the PM should start with the opensolaris.org repo)
- Click on the search magnifier without entering anything to the
search box
> Nothing is found
- Click on "Search for Search (Ctrl-F) within All Publishers"
- Very quickly click on the "Click on the Publishers below to view
their list of packages:"
"opensolaris.org"
As the result empty list of packages will be preserved in the cache
and I had to click Refresh to have it working back.
Yep I can reproduce this by searching for say testx in
opensolaris.og. It fails and displays the help page, click on search
in All Publishers, now All Publishers page is displayed and hitting
on the browse for opensolaris.org cause the problem.
I am now making sure to display the list when the search is initiated
from the Page for All Publishers. One issue I have is that the busy
cursor is not displayed over the list empty list during search.
JR
best
Michal Pryc
Joanmarie Diggs wrote:
Hi John.
I just tried it. Works quite nicely.
Thanks!
--joanie
On Mon, 2009-10-05 at 11:52 +0100, jmr wrote:
Thanks for the feedback Joanie, comments below and new webrev. I
added in your changes for 11699 as well.
webrev:
http://cr.opensolaris.org/~jmr/pm_enhance_search_ui_11669_05Oct_1145am/
bug: 11669 Enhance handling of Search All Publishers to match
current UI Spec
bug: 11699 Missing focus rectangle and missing a11y events on PM
start page
JR
Joanmarie Diggs wrote:
Hi John.
1. Most of the time, after link has been activated and the
corresponding
package list populated, nothing seems to have focus. From an a11y
standpoint, it would be helpful if *something* were given focus
after
the user activated one of the links on the new page. (The resulting
accessible focus-related events would cause Orca to present the new
location.) Therefore, is there a widget everyone can agree upon
as the
likely "next step" for the majority of users? If so, would it be
possible to put focus there?
Sure - I am now just putting the focus back in the Publisher
combobox. Seems a reasonable place to focus as you have just
switched to this Publisher in the same way as if you had clicked
in the combobox.
2. The act of getting from the Publisher combo box to the new
page via
keyboard is not unlike getting to the package list after a
search: The
user shouldn't press Tab because landing in the category tree on
the way
restores the package list. Using the Ctrl+L workaround fails
because it,
too, causes the package list to be restored.
Given that the decision was made to provide Ctrl+L rather than to
expect
the user to know to Shift+Tab after a search, would it make sense to
cause Ctrl+L to give focus to the new page in this case?
Ok if a page is displayed I focus on it, otherwise I focus on the
package list. Will see if Ann and Jyothi want a change to the Menu
item Edit->Go to package list (Ctrl-L) as it now goes to package
list or notebook page.
JR
Thanks in advance. Take care.
--joanie
On Fri, 2009-10-02 at 15:27 +0100, jmr wrote:
Michal - here is a respin:
webrev:
http://cr.opensolaris.org/~jmr/pm_enhance_search_ui_11669_02Oct_320pm/
bug: 11669 Enhance handling of Search All Publishers to match
current UI Spec
I had to rework things a bit to take account of the fact that
you can now save the last Publisher on shutdown and restore on
startup. This requires special handling for All Publishers. I
also added Jyothi's request to allow you to have a browse link
from the Search All Publishers page. This might address the
following bug, it certainly gives you a fast startup and easy
access to browsing the Publishers if you wish:
11646 Restoring All Publisher should also restore last viewed
publisher categories
JR
Michal Pryc wrote:
John,
I can see in many places html code with some strings not being
translated _().
Is it intentional ?
best
Michal
jmr wrote:
Hi here is a webrev to update some of PM's search behavior, in
particular when switching into All Publishers and when zero
results are returned. This was driven by feedback from the
usability studies.
webrev:
http://cr.opensolaris.org/~jmr/pm_enhance_search_ui_11669_01Oct_510pm/
bug: 11669 Enhance handling of Search All Publishers to match
current UI Spec
JR
From the bug:
When we switch into the All Publishers view currently the user
sees an empty
list, same is true if zero results are returned for All
Publishers or any
Publisher. Change to match the spec are as follows:
- Switching to All Publishers, display a page in the List view
location giving
users some help about the mode they are in.
- Searching in a publisher that returns zero results, display
a page giving
them some help. Also allow them to re-excute the search in All
Publishers from
this page.
- Searching in All Publisher that returns zero results,
display a page giving
them some help.
- Searching using * in All Publishers is not supported,
display a page
explaining this to the user.
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
