Michal - thanks for the feedback, I've fixed the issues below and also
added handling when View filter hides all search results. The user is
now warned and given a link to change the View: to All Packages on the
page. I've incorporated various changes from several reviews with
Padraig as well.
webrev: http://cr.opensolaris.org/~jmr/pm_enhance_search_ui_11669_08Oct_5pm/
bug: 11669 Enhance handling of Search All Publishers to match current UI
Spec
bug: 11699 Missing focus rectangle and missing a11y events on PM start page
JR
Michal Pryc wrote:
John,
It's working pretty well. I found two minor bugs and I will let you
decide what to do with them.
BUG 1:
Search for *&
> GtkWarning: Failed to set text from markup due to error parsing
markup: Error on line 1: Entity did not end with a semicolon; most
likely you used an ampersand character without intending to start an
entity - escape ampersand as &
- the status bar markup is broken, probably we need to replace all &
to & when updating statusbar.
Escape search string now so this is handled correctly.
BUG 2:
Enter space and click on magnifier search icon
> The list of packages is empty, status bar tells that 0 results were
found
- expected - nice html page should be in place, exactly like other 0
results found case
- or... do nothing when there are only spaces
Searching for spaces, just ignore and set the search field to null again.
Michal
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
