Shawn Walker wrote: > http://cr.opensolaris.org/~swalker/pkg-11384/
in add_publisher(): why remove the calls to remove_publisher_metadata()? Don't you want to remove the data after a failure? Should these be changed to another call to remove_meta_root()? line 1206: extraneous blank line? line 1354: this should use whatever constant you've introduced for bug 11735 I'd probably put the two calls to rmtree() (to remove the old catalogs) after both renames have been done. You might also want to use a new temporary name instead of appending .orig, since if something happens and those .orig directories don't get removed properly, the rename will fail. Though better yet, you could just create a temporary "state" directory one level up, and reduce your window even further. Should temporary_file() get the same try/except bits that temporary_dir() has? Danek _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
