On Wed, Oct 07, 2009 at 11:09:51AM -0700, Danek Duvall wrote: > Shawn Walker wrote: > > > http://cr.opensolaris.org/~swalker/pkg-11384/ > > in add_publisher(): why remove the calls to remove_publisher_metadata()? > Don't you want to remove the data after a failure? Should these be changed > to another call to remove_meta_root()?
The call to remove_publisher_metadata() is what triggers 11384. If the image never gets its metadata fully constructed, and the client raises an exception in valid_publisher_test() or refresh_publishers(), then remove_publisher_metadata() won't have any metadata to remove. This causes the remove_ routine to raise an exception, which masks the original error. This makes debugging problems in this path very difficult. -j _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
