Shawn Walker wrote:
> http://cr.opensolaris.org/~swalker/pkg-cat-p3-1-to-4/
client.py:
- you converted emsg() to logger.error(), but not msg() to logger.info(),
which you did in, say, bootenv.py. Why?
catalog.py:
- line 2216: might be worthwhile explaining what the difference between a
None and a [] return value is.
client/__init__.py:
- line 85: self.__error_log_handler, perhaps?
client/api.py:
- get_pkg_cat_data(): I could be missing something here, but it seems
like you treat the summary and the description completely differently.
In particular, you have a get_summ variable, but not a corresponding
get_desc -- you collect the summary only if get_summ, and set the summ
variable if it's true, but for the description, you always collect it,
and empty it out at the end if it's not been requested. Am I missing
some fundamental difference between the two?
depotcontroller.py:
- line 225: no need for a backslash
server/repositoryconfig.py:
- line 181: I don't think this is correct -- EmptyI is the empty tuple,
not a dictionary. Perhaps you want to use misc.EmptyDict?
pull.py:
- line 632: doesn't this contradict the comment on line 625? Does this
mean we can't create a new repo with pkgrecv? If so, why?
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
