Danek Duvall wrote:
Shawn Walker wrote:
http://cr.opensolaris.org/~swalker/pkg-cat-p3-1-to-4/
client.py:
- you converted emsg() to logger.error(), but not msg() to logger.info(),
which you did in, say, bootenv.py. Why?
Paranoia about the formatting of output of list, etc. Its the same
reason why I didn't change the specific print statements in progress.py
Should I change it? I was primarily attempting to target errors,
warnings, and any messages hidden from the client behind the api.
client/api.py:
- get_pkg_cat_data(): I could be missing something here, but it seems
like you treat the summary and the description completely differently.
In particular, you have a get_summ variable, but not a corresponding
get_desc -- you collect the summary only if get_summ, and set the summ
variable if it's true, but for the description, you always collect it,
and empty it out at the end if it's not been requested. Am I missing
some fundamental difference between the two?
This is the compatibility behaviour where we want to use pkg.description
if pkg.summary isn't available for older packages, hence line 897.
There may be an easier way to express this.
pull.py:
- line 632: doesn't this contradict the comment on line 625? Does this
Yes, line 625 is wrong; needs removal.
mean we can't create a new repo with pkgrecv? If so, why?
Because it was becoming too hard to manage the automatic creation of a
repository with pkgrecv and whatever possible required configuration it
may have, hence it now require users to create the repository using
pkgsend create-repository when using -d file://<path>.
That avoids the headache of having to worry about the nuances of
repository creation in pkgrecv, and it tells the user what they need to do.
I didn't want to have to add all of the command-line options, etc. that
pkgsend requires for creating a repository to pkgrecv as well.
Cheers,
--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
