Bart Smaalders wrote: Mostly nits; looks good.
> http://cr.opensolaris.org/~barts/faster-publication/ depot.py: - line 135: don't remove the blank line before this. - line 153: "indicies" -> "indices" (also in bug 12894 synopsis, and in man page) - line 522: Perhaps --refresh-index should set exit_ready, simplifying this and other tests? man/pkgsend.1.txt: - line 97: could you add --no-index to the close synopsis while you're here? publish/transaction.py: - line 348: ? server/repository.py: - line 174: no spaces around equals. I'd also call "init_search" "refresh_index" just like it is for close(). - line 622: restore blank line before this - line 747: should this break or set self.__searchdb_update_handle to None? publish.py: - should close have a --no-catalog option? - line 90: need to add --no-catalog and --fmri-in-manifest, too. - line 207: I think the "-" before the "d" is unneeded. - line 246ff: why are we doing all this work here, rather than in some centralized place, like Manifest.set_content()? Both trans_publish() and trans_include() should use that, then strip out the actions that shouldn't be there. And set_content() can be enhanced to provide line number information with errors. - line 269: why should we be paying any attention to the "fmri" attribute anymore? If it's obsolete, we shouldn't be encouraging new manifests to be written with it. Certainly, it shouldn't be documented in the manpage. Danek _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
