Danek Duvall wrote:
Code review comments from Bart and Shawn have been implemented:http://cr.opensolaris.org/~dduvall/pkg-obsolete-v1-v2/ http://cr.opensolaris.org/~dduvall/pkg-obsolete-stage-v2/ for the incremental and the full review. If anyone else is planning on reviewing the code or making any comments I'll need to do something about, please let me know before beer today (but you don't have to finish the review before then). If this is it, though, I'd like to push this afternoon.
This looks fine; you appear to have addressed the various depot restart cases I was concerned about. The only failure cases I see left now are ones where they've ignored the exit code of pkgsend for which they can only blame themselves.
Cheers, -- Shawn Walker _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
