Rich Burridge wrote:

>  http://cr.opensolaris.org/~richb/pkg-10485-v1/

image.py:

  - looks like the uuid module isn't used at all; I think you should be
    able to just remove the line.

SUNWipkg/prototype:

  - the pkg egg file creation was automatic?  Is there any way to turn it
    off?  Similarly for cherrypy and mako -- those are new, too.

SUNWpython-cherrypy/prototype

  - Why are we now shipping cherryd, but weren't before?  Is this new in
    3.1.2?

cli/t_publish_api.py, cli/t_util_merge.py, perf/*.py:

  - Shouldn't the shebang lines for these be #!/usr/bin/python?

There are a couple places we put a dependency on SUNWpython24-simplejson
into SUNWipkg:

    src/util/distro-import/121/common/SUNWipkg
    src/util/distro-import/publish_ips

You'll need to fix those up, and you'll probably want to make sure we never
publish with a dependency on SUNWPython, which would need to be updated to
SUNWPython26 if we did.  I see such a thing in brand/pkgcreatezone, at
least.  Looks also like pkg5-dev depends on SUNWPython-extra, too.

Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to