Rich Burridge wrote:
Hi,

Looking for a code review for the fixes for

 10485 move pkg(5) to Python 2.6
 http://defect.opensolaris.org/bz/show_bug.cgi?id=10485

 10482 upgrade to cherrypy 3.1.2
 http://defect.opensolaris.org/bz/show_bug.cgi?id=10482

 11836 shebang line for python modules should be python version-agnostic
 http://defect.opensolaris.org/bz/show_bug.cgi?id=11836

 11950 ldtp used by pkg build process not setup to easily use Python 2.6
 http://defect.opensolaris.org/bz/show_bug.cgi?id=11950

 11989 pkg python dependency analysis tests fail
 http://defect.opensolaris.org/bz/show_bug.cgi?id=11989


Webrev is at:

 http://cr.opensolaris.org/~richb/pkg-10485-v1/

So I was going to suggest replacing the 'import simplejson as json' statements with 'import json' since simplejson is now a core part of python as of 2.6 and newer. However, I then realised that the version of simplejson we have is newer than what is part of our python 2.6 distribution. There's also a newer (faster) version coming out "soon", so keeping this decoupled may be to our benefit.

Danek covered everything else.

Cheers,
--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to