New webrev at:
http://cr.opensolaris.org/~richb/pkg-10485-v2/
Files changes in this webrev are:
.../src/brand/pkgcreatezone
.../src/modules/client/image.py
.../src/pkgdefs/SUNWpython-cherrypy/copyright
.../src/pkgdefs/SUNWpython-cherrypy/pkginfo
.../src/tests/cli/t_publish_api.py
.../src/tests/cli/t_util_merge.py
.../src/util/distro-import/121/common/SUNWipkg
.../src/util/distro-import/122/common/pkg5-dev
.../src/util/distro-import/publish_ips
From Danek:
> image.py:
>
> - looks like the uuid module isn't used at all; I think you should be
> able to just remove the line.
Yup. (Tom mentioned the same thing). Removed.
> SUNWipkg/prototype:
>
> - the pkg egg file creation was automatic?
Yes.
> Is there any way to turn it off? Similarly for cherrypy and mako --
> those are new, too.
I couldn't find one. I'm willing to be enlightened.
Shawn also mentioned to me that various python modules use the egg files to
detect if certain modules are installed. I suggest we include them.
> SUNWpython-cherrypy/prototype
>
> - Why are we now shipping cherryd, but weren't before? Is this new in
> 3.1.2?
This is a new line in the CherryPy 3.1.2 setup.py file. (I discussed this
you and Shawn), and the plan is to leave it as it is (i.e. /usr/bin/cherryd
will be created).
> cli/t_publish_api.py, cli/t_util_merge.py, perf/*.py:
>
> - Shouldn't the shebang lines for these be #!/usr/bin/python?
For the two cli/... files, I changed them to python2.6 because they have
'if __name__ == "__main__":' sections. I understand (from you) that these
aren't used any more, so I've changed their shebang lines to
'#!/usr/bin/python'.
For the two files under .../tests/perf, I don't see any other way to run
them then via the command line, so as they are executable then they should
be '#!/usr/bin/python2.6'. Correct me if I'm wrong.
> There are a couple places we put a dependency on SUNWpython24-simplejson
> into SUNWipkg:
>
> src/util/distro-import/121/common/SUNWipkg
> src/util/distro-import/publish_ips
>
> You'll need to fix those up,
So changed.
> and you'll probably want to make sure we never
> publish with a dependency on SUNWPython, which would need to be
updated to
> SUNWPython26 if we did. I see such a thing in brand/pkgcreatezone, at
> least.
Okay. So changed.
> Looks also like pkg5-dev depends on SUNWPython-extra, too.
Okay. I changed:
SUNWPython-extra ==> SUNWPython26-extra
SUNWpython-setuptools ==> SUNWpython26-setuptools
in .../122/common/pkg5-dev
------------
From Shawn:
> Also, it looks like the pkginfo and copyright files may need updating
> for cherrypy in the related pkgdefs directory.
Okay.
VERSION line changed in .../src/pkgdefs/SUNWpython-cherrypy/pkginfo
.../CherryPy-3.1.2/cherrypy/LICENSE.txt copied to
.../src/pkgdefs/SUNWpython-cherrypy/copyright
------------
Thank you all.
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
