[email protected] wrote:
> http://cr.opensolaris.org/~johansen/webrev-13199/
Handful of nits ...
transport/engine.py:
- line 151: this comment talks about pretransfer time, but the code it
refers to (line 156) is about start transfer time.
- line 181: I'll suggest
proto_reason = tx.proto_code_map.get(proto, {}).get(httpcode, None)
though that may be too long for the line and too inconvenient to break,
so feel free to ignore the suggestion.
- line 188: not your code, but "timeouted"? Sheesh.
- line 221: any reason to care about integer divide here?
transport/stats.py
- line 49: mode 0?
- What's the lifetime of an object of this class? Is there really a
reason to keep the file open the entire time?
- line 417: Why do you have a Cospeed_none, but not a Cocspeed_none?
- line 419: why this test (and the next) if you're not worried about
division by zero? What's wrong with just printing out the raw number?
- line 419: why define a function just to set one variable, once?
file_manager.py:
- line 221: could we check e.filename == cur_full_path rather than doing
the extra stat? Not a huge deal either way.
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
