On Fri, Dec 11, 2009 at 03:18:53PM -0800, Brock Pytlik wrote:
> I don't really feel that I'd notice any structural issues w/ the
> quality code, but I've done what I could. Also, the changes in
> filemanager.py look right.
Ok, thanks for looking.
> engine.py:
> 181-185, 250-254: Could you remove the pmap variable from these
> lines and just assign proto_reason directly? It took me a while to
> realize that pmap was only a tmp variable.
>
> You could replace the entire if/else block with something like this:
> proto_reason = tx.proto_code_map.get(proto, {httpcode:None})[httpcode]
> But I don't know if that's just too complicated for its own good.
I appreciate the suggestion, but implementing it makes my lines wrap and
look somewhat confusing. I'll add a comment here to explain that we're
getting a reference to the proto_code_map kept in transport exception,
if it helps?
Thanks again for looking at this,
-j
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
