I don't really feel that I'd notice any structural issues w/ the quality
code, but I've done what I could. Also, the changes in filemanager.py
look right.
engine.py:
181-185, 250-254: Could you remove the pmap variable from these lines
and just assign proto_reason directly? It took me a while to realize
that pmap was only a tmp variable.
You could replace the entire if/else block with something like this:
proto_reason = tx.proto_code_map.get(proto, {httpcode:None})[httpcode]
But I don't know if that's just too complicated for its own good.
The rest, LGTM (stressing the "to me" part)
Brock
[email protected] wrote:
Folks,
While examining the multi-origin performance for Stephen, I ran across a
bunch of bugs in or related to the transport. This fixes the ones that
I have found so far.
http://cr.opensolaris.org/~johansen/webrev-13199/
Thanks,
-j
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
