Padraig - ran this and reviewed looks fine except for few minor comments:

398 433 def __proceed_with_stages(self, continue_operation = False):
399  434                  if continue_operation == False:
400  435                          self.__start_stage_one()
401 - gui_misc.set_modal_and_transient(self.w_dialog,
402      -                            self.w_main_window)

I know this is setup in the init but can you check its not needed if we are calling this from webinstall

JR

Padraig O'Briain wrote:


On 01/12/10 22:55, Shawn Walker wrote:
On 01/11/10 10:47 AM, Shawn Walker wrote:
On 01/11/10 10:33 AM, Padraig O'Briain wrote:
Corrected addressee.

Padraig

On 01/11/10 16:28, Padraig O'Briain wrote:
The installation just terminates.

Padraig

On 01/11/10 16:27, Shawn Walker wrote:
On 01/11/10 08:32 AM, Padraig O'Briain wrote:
I have respun the webrev,
http://cr.opensolaris.org/~padraig/ips-5732-v6/, to take account of

So what does the user see if they click reject on a license accept
window?

Okay, I have no further review comments then. I'm not certain what the
behaviour should be for the license failure case.

Padraig,

Is this going back soon?


I hope to put this back today.
I just need to walk John through the recent code changes.

Padraig
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to