On 01/ 7/10 06:19 AM, Padraig O'Briain wrote:
I have respun the webrev,
http://cr.opensolaris.org/~padraig/ips-5732-v5/, to address the comments
by Shawn and Joanie.
gui/modules/installupdate.py:
lines 1165-1168: I know it seems like a small thing, but could you
consolidate this to make a single call to set_license_status?
line 764-766: Actually, it shouldn't return here. It should go
ahead and proceed with exceution even if the user didn't accept the
licenses. This is so that the correct exception will be recorded in
client history. Be certain that PackageManager expects a
PlanLicenseErrors() exception from plan prepare() or plan execute().
Finally, are there any plans to add tests for this to the GUI test suite?
Cheers,
--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
