Thanks for the comments.
On 12/31/09 19:04, Joanmarie Diggs wrote:
Hey Padraig.
A few quick observations:
1. I think the license window should either be larger by default and/or
be resizable. The text of some licenses seems to assume sufficient room
for a given number of characters. (Not your fault, and who reads these
things anyway? But.... See attached screenshot.)
I will make it wider.
2. If you mark a package for installation, begin the installation, but
then close the license window without pressing the Accept button, the PM
process doesn't seem to terminate when you quit PM. (See attached output
from pstack.) I don't know if this an AT-related thing or not as I'm not
in a position at the moment where I can disable AT support and log out.
This is an error which I will fix.
3. Should there be some sort of "Are you sure?" dialog when the accept
button is not pressed? Maybe not.... Merely tossing it out there as the
(accidental or intentional) failure to accept the license of a given
package seems to result in the entire installation operation being
quietly canceled -- even if other licenses were accepted, and even if
the license which was not accepted is associated with a package upon
which none of the other packages to be installed depend.
I do not propose to make any change here.
4. At least one package (SUNWgobject-introspection) displays its license
twice.
This was an error on my part. I will fix it.
Padraig
Take care. (And Happy New Year!!)
--joanie
On Thu, 2009-12-31 at 13:28 +0000, Padraig O'Briain wrote:
The webrev, http://cr.opensolaris.org/~padraig/ips-5732-v2/, fixes
5732 packagemanager should have support for click-thru license
This webrev adds support for must-accept and must-display license
attributes when installing or updating packages
If a package has a license which is must-display the license is displayed.
If a package has a license which is must-accept the user must accept the
license in order to continue the installation.
Note that packages in opensolaris.org and contrib seem to have licenses
with must-display attribute set as the license is now displayed when
installing.
Padraig
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
------------------------------------------------------------------------
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
