On Wed, Jan 27, 2010 at 07:46:41PM -0800, Dan Price wrote:
>
> At long last, here's a cut at my test cleanup wad. I would
> appreciate comments.
>
> http://cr.opensolaris.org/~dp/pkg-testfu/
This looks good. I have just a few nits:
cli/t_setUp.py:
- Should this file be deleted? It's empty now, but shows up in the
webrev with the shebang changed to 2.6. If you're going to keep
this file, it also needs its copyright changed from 2008 to 2010.
pkg5unittest.py:
- lines 400, 1244, 1269, 1340: The call to communicate() already waits for
the process to terminate. You can check the returncode by looking
at s.returncode here instead.
- lines 1158/1159 and 1745/1746: Swap the order of these two function
calls. The test suite isn't reading from the pipe, so it's possible
that the application could write enough to STDOUT to fill the pipe
and block. If that happened, the call to wait would never return.
Thanks for fixing this, Dan!
-j
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
