Dan, Great stuff!
I haven't looked at this in detail yet, but here are some initial comments. - do you have a pointer to test output using the -d flag? - currently test log dirs use process ids under g_tempdir = "/tmp". I recommend test log dirs use dates in names like ipstest_20100128_122410 (YYYYMMDD_HHMMSS) and are stored under /var by default. This makes the logs persistent across reboots and makes it much easier to find logs. Also, logs by date will be needed for cteam review. - The approach to printing test case assertions (doc strings) I used short circuits testing (ie. no tests are performed) and concentrates the assertions in the output. I suggest doc strings be printed during -d like you have it, and a -A or -r option be added that implements what I have here: http://cr.opensolaris.org/~jwalker/14023/ http://mail.opensolaris.org/pipermail/pkg-discuss/2010-January/020367.html ... cli.t_pkgrecv.py TestPkgrecvMulti.test_0_opts: [Verify that various basic options work as expected and that] TestPkgrecvMulti.test_1_recv_pkgsend: [Verify that a received package can be used by pkgsend.] TestPkgrecvMulti.test_2_recv_compare: [Verify that a received package is identical to the] ... It's important to get the test assertions in better shape in preparation for cteam review. - README file should be updated (see above 14023 webrev) Cheers, Jim Dan Price wrote:
At long last, here's a cut at my test cleanup wad. I would appreciate comments. http://cr.opensolaris.org/~dp/pkg-testfu/
_______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
