On Thu 28 Jan 2010 at 10:14AM, [email protected] wrote:
> On Wed, Jan 27, 2010 at 07:46:41PM -0800, Dan Price wrote:
> >
> > At long last, here's a cut at my test cleanup wad. I would
> > appreciate comments.
> >
> > http://cr.opensolaris.org/~dp/pkg-testfu/
>
> This looks good. I have just a few nits:
>
> cli/t_setUp.py:
>
> - Should this file be deleted? It's empty now, but shows up in the
> webrev with the shebang changed to 2.6. If you're going to keep
> this file, it also needs its copyright changed from 2008 to 2010.
I thought that I was deleting this-- it might be a corner case in
webrev? I'll work on resolving it.
from my hg outgoing -v:
removed:
src/tests/cli/t_api.py
src/tests/cli/t_api_info.py
src/tests/cli/t_api_list.py
src/tests/cli/t_api_search.py
src/tests/cli/t_pkg_api_install.py
-->src/tests/cli/t_setUp.py
src/tests/cli/t_solver.py
> pkg5unittest.py:
>
> - lines 400, 1244, 1269, 1340: The call to communicate() already waits for
> the process to terminate. You can check the returncode by looking
> at s.returncode here instead.
>
> - lines 1158/1159 and 1745/1746: Swap the order of these two function
> calls. The test suite isn't reading from the pipe, so it's possible
> that the application could write enough to STDOUT to fill the pipe
> and block. If that happened, the call to wait would never return.
Ok, will fix these.
-dp
--
Daniel Price, Solaris Kernel Engineering http://blogs.sun.com/dp
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
