On 02/05/10 14:54, Shawn Walker wrote:
On 02/ 5/10 04:39 PM, Bart Smaalders wrote:
On 02/05/10 14:36, Shawn Walker wrote:
..
I thought about it, but the problem with doing startup cfg_cache checks
is that the user then gets stuck and can't use any pkg subcommand to get
unstuck. Of course they could just manually edit the cfg_cache.
If we do something here, it will probably need to be after the coming
release given that we have to minimise string changes as much as
reasonably possible.
I'm open to doing additional sanity checks on startup as long as they
don't significantly add to startup time.
Cheers,
Since I'm modifying imageconfig.py anyway to fix 14017
(http://cr.opensolaris.org/~barts/14017/), why don't I
add code to just delete lower ranked publishers w/ duplicate
names?
If you want to do that, that's ok with me. But if you do, please use
logger.warning() to log the fact that you're removing them. I know that
technically means a string change, but at least then there's a chance
that users with poorly configured images won't have publishers
mysteriously disappear.
Cheers,
I'll hold off on this for now; we can revisit this if it turns out to
be a problem.
Your code changes look fine.
- Bart
--
Bart Smaalders Solaris Kernel Performance
[email protected] http://blogs.sun.com/barts
"You will contribute more with mercurial than with thunderbird."
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
