On 02/16/10 04:27 PM, Danek Duvall wrote:
Shawn Walker wrote:

http://cr.opensolaris.org/~swalker/pkg-14292/

client.py:
...
   - line 466: use pkg.fmri.fmri_match()?

   - line 471: use pkg.fmri.glob_match()?

For both of these, using the function was much slower than in-lining the logic. That's an optimisation that was made in the work for get_pkg_list().

   - line 569: why not result=history.RESULT_NOTHING_TO_DO?

Because the operation was partially successful, so actually did something. NOTHING_TO_DO is only used when no packages were listed.

Cheers,
--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to