On 02/16/10 04:53 PM, Danek Duvall wrote:
Shawn Walker wrote:

   - line 466: use pkg.fmri.fmri_match()?

   - line 471: use pkg.fmri.glob_match()?

For both of these, using the function was much slower than in-lining
the logic.  That's an optimisation that was made in the work for
get_pkg_list().

Ugh.

To be clear, I haven't measured the impact of it here in the logic the client uses after the results have been returned by get_pkg_list(). My experience is from it contributing (seconds) to get_pkg_list() when I was writing get_pkg_list().

I'll double check here to see if the difference is as great as it was for get_pkg_list() (internally).

Cheers,
--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to