On 02/16/10 04:07 PM, Brock Pytlik wrote:
On 02/16/10 11:10 AM, Shawn Walker wrote:
Greetings,
The following webrev contains fixes for the following issue:
14292 pkg list doesn't exit with partial failure when some names are
unmatched
webrev:
http://cr.opensolaris.org/~swalker/pkg-14292/
...
346-389: couldn't this just be a call to a new api function so that this
code isn't copied from the code in api.py? That would solve the hard
coding of brelease wouldn't it? It looks to me like this code could be a
function that takes in pats, and returns illegals and pat_tubles. Am I
missing something?
So, I've looked into this. If the actual matching logic wasn't
in-lined, it might have been more beneficial since matcher function
references could have been returned. But, at this point, it looks like
I'd need to return the type of matcher instead which would mean new
ImageInterface constants or a special data structure.
In addition, since I've simplified this somewhat as the logic for
handling illegals wasn't needed (check_fmir_args handles it), it's no
longer identical to what get_pkg_list() does.
At this point in the release cycle, I'm not comfortable with making a
bigger addition to the client API, so I've added a comment here instead
about re-visiting this and having something relevant in the client API.
Cheers,
--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
