On Mon, Mar 01, 2010 at 04:41:23PM -0600, Shawn Walker wrote:
> webrev:
> http://cr.opensolaris.org/~swalker/pkg-529/

Looks good.  Just a few questions.

actions/file.py:

  - lines 441 and 453: Would it make sense to introduce another type of
    exception, similar to ActionOperationError but for unexpected
    permanant failures?  In that case, we could raise this alternate
    exception on these two lines instead of just tracing back.  The
    user would still have to debug the problem, but at least they
    wouldn't get a traceback.

actions/link.py:

  - lines 146 and 157: Same question as above.


-j
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to