On 04/ 6/10 11:42 PM, Shawn Walker wrote:
On 03/ 1/10 04:41 PM, Shawn Walker wrote:
Greetings,
The following webrev contains fixes for the following issues:
529 client can traceback with EBUSY during action removal
3286 file install fails if a parent directory has been replaced by a
link or file
3644 directory/symlink ambiguity renders package uninstallable
13069 symlink found to be a directory causes traceback on upgrade
14927 directory install won't set mode if directory already exists
14940 testsuite could use client API for image creation
webrev:
http://cr.opensolaris.org/~swalker/pkg-529/
updated webrev (full set of changes; diff not available):
http://cr.opensolaris.org/~swalker/pkg-529-2/
I believe this addresses all of the review comments received so far.
Summary of Changes:
* nuke ImageStateErrors, ActionOperationError
* use ActionExecutionError for action failures
* change client to expect ActionExecutionError
* optimise action install/remove checks by lstat'ing once
* rename image.salvagedir() to image.salvage()
* consolidate install through symlink checks
* add symlink install check to directory, link
* change makedirs to do error handling for parents of target
for ENOTDIR case
* consolidate removal logic for file and link actions
* expand ActionExecutionError capabilities for error reporting
* fix salvage stat of salvage target
* cleanup unit tests
Any last review comments? I'd like to put this back by Friday.
Cheers,
-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
