On 03/ 1/10 04:59 PM, [email protected] wrote:
On Mon, Mar 01, 2010 at 04:41:23PM -0600, Shawn Walker wrote:
webrev:
http://cr.opensolaris.org/~swalker/pkg-529/
Looks good. Just a few questions.
actions/file.py:
- lines 441 and 453: Would it make sense to introduce another type of
exception, similar to ActionOperationError but for unexpected
permanant failures? In that case, we could raise this alternate
exception on these two lines instead of just tracing back. The
user would still have to debug the problem, but at least they
wouldn't get a traceback.
The imageplan already catches any EPERM errors raised by actions and
re-raises them as an ApiPermissionsException. See lines 1113-1121 in
imageplan.py.
My assumption here was that we should only handle operation errors, or
errors that the caller cannot handle, but raise everything else.
So for now, I'd rather just leave this as-is with the assumption that
callers are responsible for handling those sorts of errors.
actions/link.py:
- lines 146 and 157: Same question as above.
See above.
Thanks for the review.
Cheers,
--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
