On Fri, Mar 12, 2010 at 11:12:12PM -0600, Shawn Walker wrote:
> webrev:
> http://cr.opensolaris.org/~swalker/pkg-mem-2/

In general this looks good.  I do have a question about solver.py lines
171, 463, 526, and 563.  Since it's possible to run Python in a mode
where assertions are disabled and these checks appear to be executed for
correctness, should this raise a known exception type instead of
generating an AssertionError?  Or, to put it another way, do we want it
to be possible for the interpreter to disable these checks?

-j
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to