On 03/16/10 06:30 PM, Shawn Walker wrote:
On 03/12/10 11:12 PM, Shawn Walker wrote:
Greetings,
The following webrev contains fixes for the following issue:
15176 imageplan keeps solver cache and catalog data too long
Added:
15211 image package installed state update could be faster
(...since making it faster also reduced memory usage slightly.)
webrev:
http://cr.opensolaris.org/~swalker/pkg-mem-2/
updated webrev (diff against 1st):
http://cr.opensolaris.org/~swalker/pkg-mem-2-v1-v2/
full webrev:
http://cr.opensolaris.org/~swalker/pkg-mem-2-v2-full/
Change Summary:
* catalog data is no longer discarded immediately after use as a
performance/memory tradeoff
* additional discards for other data now take place to offset above
* saved_files are now tracked in imageplan, not image (makes above
easier)
* solver cleanup now accepts return value arg
* image state update for package installed status moved to imageplan
* unused filters code removed from pkgplan
* unused dependents code removed from image
Testing Notes:
* i upgraded my own b133 system to b135 with this (& booted it)
* our full test suite (of course)
b131 x86 system using /dev and /extra repositories (redistributable not
installed)
===================================================================
$ pfexec pkg -R / image-update --no-refresh -n (To 135)
First Column of pmap -x total output at end of operation:
Gate Tip Peak Memory: 770,292KB
Gate Tip + 15169 Patch Peak Memory: 612,880KB
Gate Tip + 15169 Patch + This Changeset Peak Memory: 587,684KB
b133 x86 system (redistributable not installed)
===========================================
$ pfexec pkg -R / install --no-refresh system/manual
First Column of pmap -x total output at end of operation:
Gate Tip Peak Memory: 365,468KB
Gate Tip + 15169 Patch Peak Memory: 242,140KB
Gate Tip + 15169 Patch + This Changeset Peak Memory: 201,548KB
$ pfexec pkg -R / uninstall system/manual
First Column of pmap -x total output at end of operation:
Gate Tip Peak Memory: 212,628KB
Gate Tip + 15169 Patch Peak Memory: 172,588KB
Gate Tip + 15169 Patch + This Changeset Peak Memory: 172,076KB
$ pfexec pkg -R / image-update -n --no-refresh (To 135)
First Column of pmap -x total output at end of operation:
Gate Tip Peak Memory: 296,788KB
Gate Tip + 15169 Patch Peak Memory: 270,100KB
Gate Tip + 15169 Patch + This Changeset Peak Memory: 250,468KB
Below is from empty user image in /tmp/image, timings are gate tip +
15087 + 12123 compared to tip + 15087 + 12123 + 15169 + this changeset:
pkg install --no-refresh system/manual (download cached)
=================================================
b133 SPARC T5120: 1m42s -> 1m23s
pkg uninstall system/manual
======================================
b133 SPARC T5120: 35s -> 30s
I need one last review of this due to the image state update changes I
made before I'm comfortable doing a putback.
Thanks,
-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
