On 03/12/10 21:12, Shawn Walker wrote:
Greetings,

The following webrev contains fixes for the following issue:

15176 imageplan keeps solver cache and catalog data too long


thanks for doing this....

One minor change you may wish to consider is adding an
argument to self.__cleanup() and returning it....

604 rval = blank_solver.solve_install(existing_freezes, proposed_dict, new_excludes)
 605                 self.__cleanup()
 606                 return rval

becomes

return self.__cleanup(blank_solver.solve_install(existing_freezes, proposed_dict, new_excludes))

but that's minor...

What performance implications does this have for a machine w/
sufficient memory and a slow CPU?

- Bart


--
Bart Smaalders                  Solaris Kernel Performance
[email protected]       http://blogs.sun.com/barts
"You will contribute more with mercurial than with thunderbird."
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to