Bart Smaalders wrote:
> http://cr.opensolaris.org/~barts/15425/
Nits ...
generic.py:
- line 247: I'm not sure it makes sense to supot cmp() between an action
and any other object other than None. Perhaps this should be
if other is None:
return 1
on the other hand, Python seems to allow cmp() on random objects and
appears to do exactly the same thing here, so who am I to judge?
I'd put a blank line after this clause, though.
pkgdiff.py:
- line 151: format for this is to put each line inside the comprehension
on a separate line half-indented from the first line, and the closing
bracket at the original indent:
real_diffs = [
...
]
- line 152: space after comma
Thanks,
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
