On 04/20/10 07:07 PM, Bart Smaalders wrote:
http://cr.opensolaris.org/~barts/15425/
15425 action comparison dies if one argument is not an action
15699 pkgdiff exit status not correct when ignoring differences
modules/actions/generic.py:
lines 239,247: What do the action comparison timings look like from
tests/perf/actionbench.py before and after this change?
I've found in the past that isinstance() can be costly
in a "hot path".
Otherwise, modulo Danek's comments, LGTM.
Cheers,
-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
