Hey Rich,
On Thu, Apr 22, 2010 at 12:13:53AM -0400, Richard Lowe wrote:
> Richard Lowe wrote:
> > Shawn responded to a question I asked off list (that he respond to my
> > last paragraph) stating that he thinks we should try and preserve
> > ownership, but not complain if we fail to.
>
> An updated webrev, which does this, is available from:
>
> http://cr.opensolaris.org/~richlowe/pkg_15686-2
>
> Please review with caution.
Just nits from me:
repositoryconfig.py:
- line 506: I think it's entirely possible to get an EPERM error when
calling chmod(2) as well as chown(2). The os.fchmod() call should
probably be in the same try/except block as the call to
portable.chown, no?
- line 520: I know this isn't your fault, but any chance you could
replace the RuntimeError with some other kind of exception?
-j
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
