On Thu, Apr 22, 2010 at 09:19:30PM -0400, Richard Lowe wrote: > [email protected] wrote: > > Just nits from me: > > > > repositoryconfig.py: > > > > - line 506: I think it's entirely possible to get an EPERM error when > > calling chmod(2) as well as chown(2). The os.fchmod() call should > > probably be in the same try/except block as the call to > > portable.chown, no? > > We just created the file we're changing (it's the temp file), I don't > know of a case where we can create it but not then chmod it. Nobody > without PRIV_FILE_CHOWN or PRIV_FILE_CHOWN_SELF will succeed in changing > owner or group it (unless it was theirs anyway), so the chown is > expected to sometimes fail, whereas the chmod failing would be > surprising (ACLs, perhaps?) and, likely, not something that should be > ignored. > > What am I missing?
Nothing. I looked at this before I had my coffee. I forgot that this was operating on the tempfile you just created. -j _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
