Shawn Walker wrote:
> http://cr.opensolaris.org/~swalker/pkg-file/
pkg.1.txt:
- line 788: "example.org"?
file_manager.py:
- line 215: "isnerted" -> "inserted".
- line 242: and if this fails due to permissions? Shouldn't you put this
in its own try/catch block?
query_parser.py:
- line 1018: Now that _global_data_dict is no longer a class variable,
and isn't created in the constructor, what's the guarantee that we
won't get an AttributeError here?
- line 1069: should we use "with" here?
- line 1132: might as well fix the typo "staic" -> "static"
- line 1217: switch to .get()?
transport/repo.py:
- line 134: why the assignment to eurl? Indeed, there seem to be a lot
of unnecessary assignments here, but perhaps it's clearer this way.
transport/transport.py:
- line 101: why the parens?
- line 180: good candidate for a list comprehension. Though I think you
might as well just create write_caches when you have to look at it,
rather than here. You might also assert() that there's only one
element in write_caches.
- line 186: Why not make pub_caches a dict instead of a list? Then you
can do a simple test instead of looping. Or do you expect to want to
order the caches?
server/repository.py:
- line 911: I think you're better off doing a stat() of self.repo_root.
That way, you can check its result in one system call, but also if you
don't have search perms to one of its parent directories, you'll get an
exception with errno == EACCES, and can properly raise a
PermissionsException there, too.
t_api_search.py:
- line 1874: Magic!
pkg5unittest.py:
- line 1437: the second half of this or is always True; did you mwan to
have "in out" after the string?
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
