Shawn Walker wrote: > On 04/29/10 06:20 PM, Danek Duvall wrote: > >Shawn Walker wrote: > > > >>http://cr.opensolaris.org/~swalker/pkg-file/ > ... > >query_parser.py: > > > > - line 1069: should we use "with" here? > > I don't follow.
A context manager for the lock. > >server/repository.py: > > > > - line 911: I think you're better off doing a stat() of > > self.repo_root. That way, you can check its result in one system > > call, but also if you don't have search perms to one of its parent > > directories, you'll get an exception with errno == EACCES, and can > > properly raise a PermissionsException there, too. > > I hope I understood properly; I've reworked this. Yes, I like that better. Thanks, Danek _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
